replace repo_url_suffix with repo_version #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
reviewed
Oct 29, 2023
the fact that the version is the suffix of the URL is an implementation detail of the nodesource repository, which shouldn't leak to the consumers of the module
ekohl
approved these changes
Oct 29, 2023
|
The next release will be breaking anyway (in terms of SemVer). We could keep the class api compatible, but the change is easy to do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the fact that the version is the suffix of the URL is an implementation detail of the nodesource repository, which shouldn't leak to the consumers of the module
Pull Request (PR) description
This Pull Request (PR) fixes the following issues